New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Services: UI for new elements describing services, update available choices and non-academic phaselines #2542
Merged
kevinrobinson
merged 30 commits into
master
from
feature/bedford-new-services-available
Oct 25, 2019
Merged
Services: UI for new elements describing services, update available choices and non-academic phaselines #2542
kevinrobinson
merged 30 commits into
master
from
feature/bedford-new-services-available
Oct 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-services-available
…ocessors' into feature/bedford-new-services-available
…-services-available
…-services-available
…-services-available
…-services-available
…-services-available
…-services-available
kevinrobinson
changed the title
WIP: Service UI for new elements
Services: UI for new elements describing services, update available choices and non-academic phaselines
Oct 22, 2019
…-services-available
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the services UI in a few different places to show more information about service types, and support more ways that this differs across districts. It's driven by changes for folks in Bedford K5 schools.
This PR will change the services available in Bedford on deploy. There is an env switch for setting
SERVICES_INFO_DOC_URL
across districts, and this just won't be shown if not set. And there's a label that controls that per-educator as well (show_services_info
). Deploying consists of verifying changes for Bedford, incrementally deploying info across districts for test users. After that we can remove the label check in a subsequent PR.Student profile, services
Allow adding different service types, and include information about those service types if available.
Student profile, services list
Previously there was text describing different services, but this didn't apply to all districts. This PR replaces that with a link to the chart the district has made describing the meaning of different services. The intention is that if there's discussion about changes to be had, it's better to push those to docs and educator discussions rather than through
help@studentinsights.org
:Student profile, attendance and behavior
Show different service types as phaselines on these graphs, depending on per-district config.